Fix booleanValue() on a null object on Android #941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases the boolean variable skipCodeExchange may be null and cause an error. I added a check before using it. If the variable is null I will consider it false
|
Hey @federicorabbiosi, thanks for your PR. I have just created a new PR with a few more checks than this to fix this issue as I can't edit yours, hope it helps and it can get merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the boolean variable skipCodeExchange may be null and cause an error.
Fixes #672
Description
I added a check before using skipCodeExchange. If the variable is null I will consider it false
Steps to verify
Unable to reproduce. The error occured when skipCodeExchange is strangely null returning in Activity into onActivityResult after authorize()