Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a more descriptive error message for AuthorizationExceptions #886

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KevinvdBurg
Copy link

@KevinvdBurg KevinvdBurg commented Aug 23, 2023

Description

I added the Cause to the Reject Promise, for example

Error: Network error

to

Error: Network error - Cause: java.security.cert.CertPathValidatorException: Trust anchor for certification path not found.

Steps to verify

Get an error and see the extended error

@robwalkerco
Copy link
Member

Thanks for your PR @KevinvdBurg

I noticed that you only modified the error description for Android. Is iOS already providing this additional error information? If not, would you be able to update your PR to keep iOS and Android aligned?

@KevinvdBurg
Copy link
Author

Hi @robwalkerco,

I'm trying to open the iOS project, but I'm getting the following error 🤔
image

But also, I'm unsure where the iOS variant handleAuthorizationException is the naming is not consistent between the platforms. If you can point me to the right function, I can add it. :)

@carbonrobot carbonrobot added the needs-triage Waiting for a member of the team to confirm label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Waiting for a member of the team to confirm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants