Skip to content

feat(forest mcp): add the authorize handler #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VincentMolinie merged 5 commits into from
Dec 4, 2025
Merged

feat(forest mcp): add the authorize handler #1341

VincentMolinie merged 5 commits into from
Dec 4, 2025

Conversation

@VincentMolinie
Copy link
Member

@VincentMolinie VincentMolinie commented Dec 1, 2025

Definition of Done

CU-86c6ur5fq

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Dec 1, 2025 •
edited
Loading

1 new issue

Tool Category Rule Count
qlty Structure Function with high complexity (count = 13): handleRequest 1

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@qltysh
Copy link

qltysh bot commented Dec 1, 2025 •
edited
Loading

Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff.

Total Coverage: This PR will not change total coverage.

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@VincentMolinie VincentMolinie force-pushed the feat/forest-mcp/authorize branch from 8dc7ac7 to 341e1c7 Compare December 2, 2025 16:13
@VincentMolinie VincentMolinie force-pushed the feat/forest-mcp/authorize branch from 341e1c7 to 5d80061 Compare December 3, 2025 10:07
@VincentMolinie VincentMolinie changed the base branch from main to feat/forest-mcp/main December 3, 2025 10:09
EnkiP
EnkiP reviewed Dec 4, 2025
View reviewed changes
packages/mcp-server/src/forest-oauth-provider.ts Outdated
const response = await fetch(`${this.forestServerUrl}/oauth/register/${clientId}`, {
method: 'GET',
headers: {
'forest-secret-key': process.env.FOREST_ENV_SECRET,
Copy link
Member

@EnkiP EnkiP Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authentication is not needed, this is a public endpoint

@VincentMolinie VincentMolinie merged commit 0a1b5e3 into feat/forest-mcp/main Dec 4, 2025
1 of 2 checks passed
@VincentMolinie VincentMolinie deleted the feat/forest-mcp/authorize branch December 4, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EnkiP EnkiP EnkiP approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VincentMolinie @EnkiP