Feature/Remote control radio and climate parameter update #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDL remote control shall allow a mobile application to know which HD sub-channel index has a signal, so that the app can tune the HD radio to that sub-channel successfully. According to this motivation, "availableHDs" parameter of RadioControlData structure marks as deprecated since 5.1 API version and add new parameter "availableHdChannels" that is a collection of available HD radio channels. This parameter will be available since 5.1 API version. Also "availableHDsAvailable" parameter of RadioControlCapabilities structure marks as deprecated since 5.1 API version and add new parameter "availableHdChannelsAvailable" that will be available since 5.1 API version. SDL remote control shall allow a mobile application to turn the climate control on or off if the vehicle supports it. According to this motivation, "climateEnable" parameter add to ClimateControlData structure. Also "climateEnableAvailable" parameter add to ClimateControlCapabilities structure.
IGapchuk
changed the title
IGapchuk
changed the title
LuxoftAKutsan
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for review.
Risk
This PR makes major API changes.
Summary
SDL remote control shall allow a mobile application to know which HD
sub-channel index has a signal, so that the app can tune the HD radio
to that sub-channel successfully.
According to this motivation, "availableHDs" parameter of RadioControlData
structure marks as deprecated since 5.1 API version and add new parameter
"availableHdChannels" that is a collection of available HD radio channels.
This parameter will be available since 5.1 API version.
Also "availableHDsAvailable" parameter of RadioControlCapabilities
structure marks as deprecated since 5.1 API version and add new parameter
"availableHdChannelsAvailable" that will be available since 5.1 API
version.
SDL remote control shall allow a mobile application to turn the climate
control on or off if the vehicle supports it.
According to this motivation, "climateEnable" parameter add to
ClimateControlData structure. Also "climateEnableAvailable" parameter add
to ClimateControlCapabilities structure.
NOTE: Please, pay attention, API version of deprecated parameters was downgrade for correct manual and auto testing.
Changelog
Breaking Changes
In RadioControlData:
In RadioControlCapabilities:
In ClimateControlCapabilities:
In ClimateControlData:
Other parts of delivery:
CI activities: http://opensdl-jenkins.luxoft.com:8080/view/remote_control_radio_and_climate_parameter_update/
HMI Integration guidelines: Ford-Luxoft/sdl_hmi_integration_guidelines#4
SDL requirements: smartdevicelink/sdl_requirements#118
ATF scripts: Ford-Luxoft/sdl_atf_test_scripts#5
HMI: Ford-Luxoft/sdl_hmi#8
CLA