Skip to content

Fix for add polygon feature not rendering as expected #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javier-godoy merged 2 commits into from
May 30, 2025
Merged

Fix for add polygon feature not rendering as expected #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
229373b
build: update web-component version to 3.8.2
paodb May 30, 2025
757cc88
fix: set the slot attribute to GoogleMapPoly
paodb May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
@SuppressWarnings("serial")
@Tag("google-map")
@JsModule("@flowingcode/google-map/google-map.js")
@NpmPackage(value = "@flowingcode/google-map", version = "3.8.1")
@NpmPackage(value = "@flowingcode/google-map", version = "3.8.2")
@NpmPackage(value = "@googlemaps/markerclusterer", version = "2.0.8")
@JsModule("./googlemaps/geolocation.js")
public class GoogleMap extends Component implements HasSize {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapMarker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
@SuppressWarnings("serial")
@Tag("google-map-marker")
@JsModule("@flowingcode/google-map/google-map-marker.js")
@NpmPackage(value = "@flowingcode/google-map", version = "3.8.1")
@NpmPackage(value = "@flowingcode/google-map", version = "3.8.2")
@NpmPackage(value = "@googlemaps/markerclusterer", version = "2.0.8")
public class GoogleMapMarker extends Component {

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
@SuppressWarnings("serial")
@Tag("google-map-point")
@JsModule("@flowingcode/google-map/google-map-point.js")
@NpmPackage(value = "@flowingcode/google-map", version = "3.8.1")
@NpmPackage(value = "@flowingcode/google-map", version = "3.8.2")
@NpmPackage(value = "@googlemaps/markerclusterer", version = "2.0.8")
public class GoogleMapPoint extends Component {

Expand Down
3 changes: 2 additions & 1 deletion src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
@Tag("google-map-poly")
@JsModule("@flowingcode/google-map/google-map-poly.js")
@JsModule("@flowingcode/google-map/google-map-point.js")
@NpmPackage(value = "@flowingcode/google-map", version = "3.8.1")
@NpmPackage(value = "@flowingcode/google-map", version = "3.8.2")
@NpmPackage(value = "@googlemaps/markerclusterer", version = "2.0.8")
public abstract class GoogleMapPoly extends Component {

Expand All @@ -57,6 +57,7 @@ public GoogleMapPoly(List<GoogleMapPoint> points) {
setFillColor(DEFAULT_FILL_COLOR);
setFillOpacity(DEFAULT_FILL_OPACITY);
setPoints(points);
getElement().setAttribute("slot", "objects");
}

public void setFillOpacity(double opacity) {
Expand Down