Adding LWT/Birth/Death messages #52

hardillb · 2025-12-02T15:30:23Z

fixes FlowFuse/flowfuse#6072

Description

Adds support for creating LWT/Birth/Death messages for the FF-MQTT nodes

Related Issue(s)

FlowFuse/flowfuse#6072

Checklist

Labels

Includes a DB migration? -> add the area:migration label

fixes FlowFuse/flowfuse#6072

hardillb · 2025-12-05T15:00:00Z

@Steve-Mcl I may have "hacked" the relinking logic (that can probably be removed now there is a real conf node.)

Steve-Mcl

quick review before pull & test shows auto linking (to platform) appears to be impossible in this PR?

test/unit/ff-mqtt_spec.js

nodes/ff-mqtt.js

Co-authored-by: Stephen McLaughlin <[email protected]>

Steve-Mcl · 2025-12-18T08:58:07Z

Ben, I see you have re-requested a review here.
I think you missed my review comment about the automatic link up will no longer work.

I did a local pull & try out to double check my suspicions and I can confirm the auto link up is broken.

Steps:

New hosted instance
Drop ff-mqtt node
Deploy

Note:

forge endpoint /api/v1/teams/:teamId/broker/client/:username/link is never called
no entry in clients table
node sits there "connecting"

… lwt-messages

hardillb · 2025-12-19T11:57:52Z

@Steve-Mcl I think I've fixed the linking now

Steve-Mcl · 2025-12-29T13:28:45Z

@Steve-Mcl I think I've fixed the linking now

Yes, link up working now 👍

However, I dont think the multiple config node containment works as expected. I imported a flow from another instance and I got 2 broker nodes:

Also, we really should do something with the config editor button:

I propose we just use the built in standard/familiar node-red config tools but remove the add button e.g. in oneditprepare, we do something like $('#node-input-btn-broker-add').hide() e.g:

Steve-Mcl · 2025-12-29T13:36:36Z

I propose we just use the built in standard/familiar node-red config tools but remove the add button e.g. in oneditprepare, we do something like $('#node-input-btn-broker-add').hide() e.g:

If this is problemaric (timing wise) then lets at least add the utility class and a label (and move it into the 2nd row) e.g.:

This is what would be rendered:

    <div class="form-row">
        <label><i class="fa fa-cog"></i> Config</label>
        <button id="node-input-lwt-placeholder" class="red-ui-button">LWT/Birth/Death Messages</button>
    </div>

Key parts to the above:

add class="red-ui-button" to the button
add a label element to have the node-red css line things up
add an fa icon (cog?) to the label

hardillb · 2025-12-29T13:47:12Z

I've gone with the second option as we don't want the drop down at all as there should only be one instance of the config node.

The import bit will need some work, but I assume this is a problem the Dashboard v2 has solved?

Steve-Mcl · 2025-12-29T15:03:56Z

The import bit will need some work, but I assume this is a problem the Dashboard v2 has solved?

You know what they say about assume ;)

Nope. at least not last time i checked. Instead, dashboard tells user (in the /dashboard) there are multiple bases. We don't have that luxury (also its clunky)

Steve-Mcl · 2026-01-05T08:56:15Z

The import bit will need some work, but I assume this is a problem the Dashboard v2 has solved?

You know what they say about assume ;)

Nope. at least not last time i checked. Instead, dashboard tells user (in the /dashboard) there are multiple bases.

Ben, I revisited this. The duplication on import issue not handled in dashboard is when 2 pages have the same endpoint URL but it seems the import of a ui-base is handled - see the below linked areas of code - in particular the use of RED.events.on 'nodes:add',...)

https://github.com/FlowFuse/node-red-dashboard/blob/fd95cf0448a0fbc5172e357e2bff2884b07178fc/nodes/config/ui_base.html#L693-L727

https://github.com/FlowFuse/node-red-dashboard/blob/fd95cf0448a0fbc5172e357e2bff2884b07178fc/nodes/config/ui_base.html#L1183-L1199

hardillb · 2026-01-06T10:04:59Z

@Steve-Mcl I think I've got the deduplicate config node code working (after the pointer from ui-base)

Steve-Mcl · 2026-01-06T10:14:50Z

@Steve-Mcl I think I've got the deduplicate config node code working (after the pointer from ui-base)

I'll take a look later. I appreciate you are pretty much AFK now so will do what is necessary to get it approved/merged.

nodes/ff-mqtt.html

Steve-Mcl · 2026-01-06T15:33:47Z

bah - even with the debounce instanced it still lets additional configs in...

Working on it now Ben!

We cannot use this as it fires even just cursoring past it in the quick-add list. This then causes config nodes to be built and added to flow even though user never added a node

- build config here instead of onadd handler - ensure history is correct - ensure UI is updated (updateConfigNodeUsers, config.refresh)

Steve-Mcl · 2026-01-06T19:32:07Z

@hardillb I have pushed a few changes - noteably:

fixed the debounce fn
removed the nodes onadd handlers - these are firing even just cursoring through the quick-add list (and were causing config node to be added when it shouldnt)
- note - that means i had to move the config node creation to the singletonLWTConfig function - which tbf deduplicates it and makes history tracking easier.
added history for undo (to remove programmatically added config node)
ensure config node users are updated and config UI side bar is refreshed

Tomorrow i will further check UI and test operation parts - but so far so good.

Steve-Mcl · 2026-01-07T09:45:17Z

Testing:

Getting issue with updating status when publishing to a topic not permitted:

This only happens if you publish with QOS 1 or 2 first (to generate a "prohibited" status) then publish on QOS 0.

~~Investigating~~

UPDATE: Resolved in 9ef343d

Steve-Mcl · 2026-01-07T09:53:03Z

Testing:

The config node has some issues:

UPDATE: Resolved

Result:

Steve-Mcl · 2026-01-07T10:04:42Z

Testing:

Issue with cycling connect/disconnect when LWT is adjusted and flow deployed

UPDATE: additional info

Looking at NR logs we see:

Broker mq:hosted:d0bg4xgpR5:2ac10a76-d70b-4804-9682-a86b99446b71@mqtt://172.17.202.183:1883 disconnected client: 142 
07/01/2026 10:18:39  [info]    Connected to broker: mq:hosted:d0bg4xgpR5:2ac10a76-d70b-4804-9682-a86b99446b71@mqtt://172.17.202.183:1883
07/01/2026 10:18:44  [info]    Broker mq:hosted:d0bg4xgpR5:2ac10a76-d70b-4804-9682-a86b99446b71@mqtt://172.17.202.183:1883 disconnected client: 142 
07/01/2026 10:18:44  [info]    Connected to broker: mq:hosted:d0bg4xgpR5:2ac10a76-d70b-4804-9682-a86b99446b71@mqtt://172.17.202.183:1883
07/01/2026 10:18:49  [info]    Broker mq:hosted:d0bg4xgpR5:2ac10a76-d70b-4804-9682-a86b99446b71@mqtt://172.17.202.183:1883 disconnected client: 142 
07/01/2026 10:18:49  [info]    Connected to broker: mq:hosted:d0bg4xgpR5:2ac10a76-d70b-4804-9682-a86b99446b71@mqtt://172.17.202.183:1883
07/01/2026 10:18:55  [info]    Broker mq:hosted:d0bg4xgpR5:2ac10a76-d70b-4804-9682-a86b99446b71@mqtt://172.17.202.183:1883 disconnected client: 142 
07/01/2026 10:18:55  [info]    Connected to broker: mq:hosted:d0bg4xgpR5:2ac10a76-d70b-4804-9682-a86b99446b71@mqtt://172.17.202.183:1883

The number 142 is the v5 rich error code which essentially means "session take over" ref - this loosly means another connection with the same Client ID was established, kicking the older session off to allow the new one - so I suspect there is a deploy cleanup issue leaving old broker node in memory when the LWT config is edited.

UPDATE: Resolved

Fixed in a078aec by adding the on-close handler

…eflecting state

…nection

Steve-Mcl · 2026-01-07T11:18:04Z

Testing:

birthMsg, closeMsg and willMsg options are not persisted nor applied to the MQTT messages

Investigating

UPDATE: Resolved

Settings were not being saved and therefore not applied to messages.

This is reloved in 5322132

Test results:

Steve-Mcl · 2026-01-07T11:49:06Z

@hardillb I have pushed all fixes and im confident this is ready now - however I should now probably not be the person to review and merge! I'll ping on eng channel see if it someone can pick up and review.

Adding LWT/Birth/Death messages

4ccd19c

fixes FlowFuse/flowfuse#6072

hardillb self-assigned this Dec 2, 2025

hardillb added 7 commits December 2, 2025 15:32

fix lint

49fe669

all the lint

0ba75e1

Frontend working (needs styling)

e0da296

fix lint

aa39184

Basically working (needs testing)

ba72786

Fix tests

72479bc

Working...

62c1be4

hardillb requested a review from Steve-Mcl December 5, 2025 14:23

hardillb marked this pull request as ready for review December 5, 2025 14:23

hardillb marked this pull request as draft December 5, 2025 14:26

hardillb marked this pull request as ready for review December 5, 2025 14:48

Add missing file

cdda04c

Steve-Mcl reviewed Dec 15, 2025

View reviewed changes

test/unit/ff-mqtt_spec.js Outdated Show resolved Hide resolved

nodes/ff-mqtt.js Outdated Show resolved Hide resolved

Update test/unit/ff-mqtt_spec.js

4b973c3

Co-authored-by: Stephen McLaughlin <[email protected]>

hardillb requested a review from Steve-Mcl December 15, 2025 13:33

hardillb added 2 commits December 19, 2025 11:55

Fix linking

d9198c6

Merge branch 'lwt-messages' of github.com:FlowFuse/nr-mqtt-nodes into…

a3b5e61

… lwt-messages

hardillb added 2 commits December 29, 2025 13:42

style the LWT button

6b943b2

Do both in and out nodes

ed724b0

Deduplicate LWT config nodes

29c4ab7

Steve-Mcl reviewed Jan 6, 2026

View reviewed changes

nodes/ff-mqtt.html Show resolved Hide resolved

Steve-Mcl added 4 commits January 6, 2026 19:26

remove onadd handlers

aa356ab

We cannot use this as it fires even just cursoring past it in the quick-add list. This then causes config nodes to be built and added to flow even though user never added a node

linting

2d3f2bf

fix debounce

2259c45

Refactor singleton LWT configuration handling:

b99d519

- build config here instead of onadd handler - ensure history is correct - ensure UI is updated (updateConfigNodeUsers, config.refresh)

Steve-Mcl added 6 commits January 7, 2026 10:22

fix remaining UI issues with node status/config count not correctly r…

2f01691

…eflecting state

fix thrown exception when error state is cleared

9ef343d

fix: add close handler for static broker node to ensure proper discon…

a078aec

…nection

fix: update i18n keys for QoS and retain labels

8a58bdb

fix: local i18n translations

9f612d0

fix: implement LWT configuration sections for MQTT broker node

5322132

fix: add LWT message saving functionality in MQTT configuration

691a8bf

Steve-Mcl added 2 commits January 7, 2026 11:52

Merge branch 'main' into lwt-messages

f2aa171

lint

ae16a75

Steve-Mcl requested a review from knolleary January 7, 2026 12:06

Adding LWT/Birth/Death messages #52

Are you sure you want to change the base?

Adding LWT/Birth/Death messages #52

Uh oh!

Conversation

hardillb commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Checklist

Labels

Uh oh!

hardillb commented Dec 5, 2025

Uh oh!

Steve-Mcl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Steve-Mcl commented Dec 18, 2025

Uh oh!

hardillb commented Dec 19, 2025

Uh oh!

Steve-Mcl commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Steve-Mcl commented Dec 29, 2025

Uh oh!

hardillb commented Dec 29, 2025

Uh oh!

Steve-Mcl commented Dec 29, 2025

Uh oh!

Steve-Mcl commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardillb commented Jan 6, 2026

Uh oh!

Steve-Mcl commented Jan 6, 2026

Uh oh!

Uh oh!

Steve-Mcl commented Jan 6, 2026

Uh oh!

Steve-Mcl commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Steve-Mcl commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Steve-Mcl commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

UPDATE: Resolved

Uh oh!

Steve-Mcl commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

UPDATE: additional info

UPDATE: Resolved

Uh oh!

Steve-Mcl commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

UPDATE: Resolved

Uh oh!

Steve-Mcl commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hardillb commented Dec 2, 2025 •

edited

Loading

Steve-Mcl commented Dec 29, 2025 •

edited

Loading

Steve-Mcl commented Jan 5, 2026 •

edited

Loading

Steve-Mcl commented Jan 6, 2026 •

edited

Loading

Steve-Mcl commented Jan 7, 2026 •

edited

Loading

Steve-Mcl commented Jan 7, 2026 •

edited

Loading

Steve-Mcl commented Jan 7, 2026 •

edited

Loading

Steve-Mcl commented Jan 7, 2026 •

edited

Loading