Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a dev-mode device at Stage 0 to be triggered #5089

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

knolleary
Copy link
Member

@knolleary knolleary commented Feb 7, 2025

Closes #5079

Description

This updates the UI constraints applied around Pipelines to allow a Device in Dev Mode to be a valid first stage in a pipeline.

This simplifies the workflow for using pipelines with Dev Mode devices; you don't have to take the device out of dev mode in order to move its snapshot to other devices.

This is a simple iteration that allows for the existing Deploy Actions to be chosen. There is scope to add a 'Create Snapshot' action - but that would only work if the device was in dev mode. Given the complications that introduces, in the spirit of fast iteration, I'm going with the existing available actions.

The workflow is then:

  1. Put device in dev mode, work on flows
  2. When ready to deploy via pipeline, create a snapshot (or rely on the auto-snapshot from your last deploy)
  3. Ensure the pipeline stage is configured to 'use latest snapshot' - not 'use active snapshot'.

This last point is one small potential gotcha. Whilst the device is in dev mode, the 'active' snapshot is whatever snapshot was deployed to the device before it was put into dev mode. The 'latest' snapshot is the most recently created one.

In terms of UX changes, for a Stage0 device in dev mode, I've removed the red warning banner, but left the warning text in place.

image

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (f39d095) to head (0815eed).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5089   +/-   ##
=======================================
  Coverage   78.40%   78.40%           
=======================================
  Files         329      329           
  Lines       15501    15501           
  Branches     3582     3582           
=======================================
  Hits        12154    12154           
  Misses       3347     3347           
Flag Coverage Δ
backend 78.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary requested a review from Steve-Mcl February 7, 2025 15:21
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve :)

@Steve-Mcl Steve-Mcl merged commit 5776a61 into main Feb 7, 2025
21 checks passed
@Steve-Mcl Steve-Mcl deleted the 5079-allow-dev-mode-device-in-pipeline branch February 7, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to deploy pipeline from a device in Developer Mode
2 participants