Skip to content

fix(music): close the mini player with a quick flick down - #2078

Merged
A-EDev merged 2 commits into
mainfrom
fix/music-bar-flick-close
Nov 14, 2026
Merged

A-EDev merged 2 commits into
mainfrom
fix/music-bar-flick-close

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The music bar's velocity tracker was fed the pointer position in the bar's own coordinates, but the bar moves down with the finger, so a flick measured close to zero speed and only a 32 dp pull closed it. With the navigation bar scrolled away, the bar sits 8 dp above the gesture area and there is little room for that pull.
  • The tracker now uses Compose's addPointerInputChange, which accumulates position deltas for a moving node, the same as the queue sheet and FlowBottomSheet.
  • The close fling threshold is now 300 dp/s instead of 800 px/s, so it feels the same on every screen density.
  • The bar's position is unchanged.

Related issue

Closes #2064

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug (passes)
  • ./gradlew :app:testGithubDebugUnitTest (6013 tests, 0 failed, run on all seven branches merged together)
  • I ran any additional flavor-specific build or test tasks affected by this change. :app:compileFossDebugKotlin and spotlessCheck pass.
  • I manually tested the affected behavior on an Android device or emulator.

Test device and Android version: Resizable emulator, API 37, phone layout. With the nav bar hidden, an 80 px flick in 20 ms closes the bar with this change; the same flick left the bar in place 3 out of 3 times on main.

Screenshots or recordings

Risk and compatibility

Gesture plumbing only. Upward drags also get the real speed now; they already decide on distance first (over 5 dp).

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 14, 2026 14:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces labels Nov 14, 2026
@A-EDev
A-EDev merged commit e2008cf into main Nov 14, 2026
9 checks passed
@A-EDev
A-EDev deleted the fix/music-bar-flick-close branch November 14, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: music player closing releted

2 participants