Skip to content

fix(ui): stop menus crashing when they change height while opening - #2077

Merged
A-EDev merged 2 commits into
mainfrom
fix/sheet-strict-offset-check
Nov 14, 2026
Merged

A-EDev merged 2 commits into
mainfrom
fix/sheet-strict-offset-check

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Turns off Material 3's strict anchored-offset check once in FlowApplication.onCreate, the opt-out M3 provides for this crash.
  • The [Bug]: lyrics drawer lag #2065 report names the cause: a long-press menu (QuickActionsSheet, the only sheet that can stop half way) heading for its half-way stop after its content became shorter than half the window. M3 dropped that anchor and threw AnchoredDraggableUninitializedException while placing it. With the check off, the sheet is placed a frame later instead.
  • Still needed on Compose BOM 2026.11.00: the flag defaults to true in M3 1.5.0-rc01 too.

Related issue

Closes #2065
Closes #2047

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug (passes)
  • ./gradlew :app:testGithubDebugUnitTest (6013 tests, 0 failed, run on all seven branches merged together)
  • I ran any additional flavor-specific build or test tasks affected by this change. :app:compileFossDebugKotlin and spotlessCheck pass.
  • I manually tested the affected behavior on an Android device or emulator.

Test device and Android version: Not tested on a device; the crash was not reproduced.

Screenshots or recordings

Risk and compatibility

One static flag set at startup, before any composition. No preference, schema or permission change.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 14, 2026 14:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 14, 2026
@A-EDev
A-EDev merged commit d7b0eaa into main Nov 14, 2026
9 checks passed
@A-EDev
A-EDev deleted the fix/sheet-strict-offset-check branch November 14, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: lyrics drawer lag [Bug]: RuntimeException in RuntimeInit.java:575

2 participants