Repository navigation
fix(ui): stop menus crashing when they change height while opening - #2077
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlowApplication.onCreate, the opt-out M3 provides for this crash.QuickActionsSheet, the only sheet that can stop half way) heading for its half-way stop after its content became shorter than half the window. M3 dropped that anchor and threwAnchoredDraggableUninitializedExceptionwhile placing it. With the check off, the sheet is placed a frame later instead.Related issue
Closes #2065
Closes #2047
Change type
Validation
./gradlew :app:assembleGithubDebug(passes)./gradlew :app:testGithubDebugUnitTest(6013 tests, 0 failed, run on all seven branches merged together):app:compileFossDebugKotlinandspotlessCheckpass.Test device and Android version: Not tested on a device; the crash was not reproduced.
Screenshots or recordings
Risk and compatibility
One static flag set at startup, before any composition. No preference, schema or permission change.