Skip to content

feat(player): draw captions in the app font - #2053

Merged
A-EDev merged 2 commits into
mainfrom
feat/captions-app-font
Nov 13, 2026
Merged

A-EDev merged 2 commits into
mainfrom
feat/captions-app-font

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Captions now use the app font, including a custom one, at the weight the caption Bold switch picks. With a variable font the Bold switch uses its real bold.
  • The system font keeps the same caption typefaces as before.
  • Covers the video player, the TV player and the caption style preview.

Related issue

Closes #1427

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest: passed (5931 tests with the branches of this batch merged on current main, 0 failed)
  • I ran any additional flavor-specific build or test tasks affected by this change. spotlessCheck and :app:compileFossDebugKotlin passed
  • I manually tested the affected behavior on an Android device or emulator. With Google Sans Flex as the app font, captions draw in it.

Test device and Android version: POCO X6 Pro 5G, Android 16 (HyperOS)

Screenshots or recordings

Risk and compatibility

No new setting. Widgets and notifications keep the system font, as the Font screen says.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 21:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces labels Nov 13, 2026
@A-EDev
A-EDev merged commit 1a6020a into main Nov 13, 2026
9 checks passed
@A-EDev
A-EDev deleted the feat/captions-app-font branch November 13, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Use App font in Captions

2 participants