-
Notifications
You must be signed in to change notification settings - Fork 45
Fix/file upload example #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix/file upload example #1709
Conversation
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Documentation build overview
Show files changed (3 files in total): 📝 3 modified | ➕ 0 added | ➖ 0 deleted
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
|
@Flix6x if you add a changelog entry, this can be merged! |
|
I actually think it needs another iteration. Rather than exposing the hidden setting (which this PR is currently doing), @nhoening and I discussed (and I think we agreed) restricting its use to play servers instead. |
Description
documentation/changelog.rstLook & Feel
wip
How to test
tbd
Further Improvements
Discussion in progress (see #1708).
Related Items
Closes #1708.