-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/run doctests #1347
Ci/run doctests #1347
Conversation
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
This reverts commit 5bedeca.
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we not actually running the doctests you have fixed here in these two modules?
- data/models/data_sources
- data/services/utils
One is actually passing, but the other is just serving as an example. In general, some of our docstrings contain examples that can't actually run without an app context. Should I add a CI step for just the one extra docstring that is passing as a doctest? |
No, only if we might add some more there. |
Any other changes requested, or would you approve this PR? |
I approve |
Description
documentation/changelog.rst
Look & Feel
Here's an example doctest we have:
How to test
The CI takes care of this.
Further Improvements
Some of our other subpackages have some doctests, too. Some of them require app contexts and I couldn't get that to work easily. Most of them also appear to be meant more like an example than as a unit test. I usually only made use of doctests as unit tests for util functions.