Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions: upload-artifact and download-artifact #98

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

VladIftime
Copy link
Contributor

No description provided.

…tarted implemenation of trigger_schedule for PPBC simple

Signed-off-by: Vlad Iftime <[email protected]>
@nhoening
Copy link
Contributor

If you need a review, please request one :)

@Flix6x
Copy link
Contributor

Flix6x commented Jan 17, 2025

@VladIftime you can tell GitHub to automatically close an associated issue by commenting on the PR like this:

Closes #97.

At least, that's what should happen. Not sure why the issue doesn't appear to be linked yet. Maybe this doesn't work correctly in the GH app.

@VladIftime VladIftime merged commit 1977344 into main Jan 17, 2025
6 checks passed
@VladIftime VladIftime deleted the maintain-upgrade-actions branch January 17, 2025 12:38
@VladIftime VladIftime requested review from nhoening and Flix6x January 17, 2025 13:47
@nhoening
Copy link
Contributor

Usually one merges after reviews are in :)

Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TenneT style.

@VladIftime
Copy link
Contributor Author

WhatsApp Image 2025-01-20 at 18 38 39
did not have the option to request the review again, sorry :/

@nhoening
Copy link
Contributor

You can also ask in writing here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants