Skip to content

Refactor: vectorize rotate_vectors, remove per-vertex loop#8

Open
maayanmatsliah-tech wants to merge 1 commit intoFlamethr0wer:mainfrom
maayanmatsliah-tech:main
Open

Refactor: vectorize rotate_vectors, remove per-vertex loop#8
maayanmatsliah-tech wants to merge 1 commit intoFlamethr0wer:mainfrom
maayanmatsliah-tech:main

Conversation

@maayanmatsliah-tech
Copy link
Copy Markdown

Wow, this is a cool repo! I made a small cleanup to the rotate_vectors function in polygon_packer.py:

  • Replaced the per-vertex loop with column-wise numpy operations
  • Removed temporary vecx and vecy variables

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant