fix(deploy): use same task definition for API and SDK services #6495
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse the task definition ARN from the API deployment for the SDK service instead of calling the deploy action twice. This ensures both services use the exact same task definition revision. Previously, each call to amazon-ecs-deploy-task-definition registered a new revision, causing SDK to be one version ahead of API.
gagantrivedi
requested review from
talissoncosta
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6495 +/- ##
==========================================
+ Coverage 98.07% 98.08% +0.01%
==========================================
Files 1294 1296 +2
Lines 46537 46616 +79
==========================================
+ Hits 45639 45724 +85
+ Misses 898 892 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gagantrivedi
requested review from
a team and
emyller
and removed request for
a team and
talissoncosta
matthewelwell
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Fix bug where API and SDK ECS services were using different task definition revisions.
Problem: The
amazon-ecs-deploy-task-definitionaction registers a new task definition revision each time it's called. When called twice (once for API, once for SDK), the SDK service ended up with revision N+1 while API had revision N.Solution:
aws ecs update-servicefor the SDK service with the same ARN instead of calling the deploy action againNow both services use the exact same task definition revision.
How did you test this code?