Exclude transient query parameter from identities request when false

[sergeirr]

Currently, get identities request contains transient query parameter only when set to true.

Previously, this bug would result in an unexpected flag state for the user identity.

• Implemented according to iOS library implementation.
• Covered with test.

[matthewelwell]

Hi @sergeirr , thanks for the contribution. I have a feeling, however, that this is a duplicate of a PR that was merged earlier this week here?

[sergeirr]

Hi @matthewelwell, actually, this is another side of the issue.
PR you mentioned covered responce part, but my PR covers request part.

[matthewelwell]

Hi @matthewelwell, actually, this is another side of the issue. PR you mentioned covered responce part, but my PR covers request part.

I'm not sure I understand what you mean by 'response' part, but on inspection, I think that the PR I shared only covers the POST by modifying the request / json body, not the GET request.

@rolodato are you able to contribute to the conversation here?

[sergeirr]

@matthewelwell Anyway, we found this issue using 1.7.3 (the latest) version.
When transient exists (even it false) as query parameter server responds with default value.
This PR fixes the issue.

[matthewelwell]

Ok, thanks @sergeirr - is there a way to catch this further upstream though? It seems like the queryInterceptor is having to correct something that's happened earlier in the URL building - couldn't we just prevent the query parameter being added earlier in the codepath?

[sergeirr]

@matthewelwell yes, we can use null value for transient query parameter, but we will face necessity to add check like:

if (transient) transient else null

to every function call (currently there are 2 calls that use transient parameter).

But this may cause misunderstandings in the future.