Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to v0.5.0 #7

Merged

Conversation

niilptr
Copy link
Contributor

@niilptr niilptr commented Mar 7, 2025

This PR upgrades the core dependencies of Firmachain and adds new sdk core modules and ibc applications.

In particular:

  • upgrades CosmosSDK to v0.50.12
  • upgrades CometBFT to v0.38.17
  • upgrades Wasmd to v0.54.0 which runs WasmVM v2.2.1
  • upgrades IbcGo to v8.6.1
  • adds the x/circuit sdk module
  • adds the packet-forward-middleware ibc middleware
  • adds the ibc-hooks ibc module
  • adds the ibc-fee ibc module
  • adds the ica-host ibc module
  • adds the icq ibc module
  • removes the unused custom x/burn module

Also, the new v0.5.0 upgrade handler:

  • handles the params migration from the legacy params module to the respective modules' keepers
  • handles the gov proposals migration adding the respective proposals' proposer
  • sets the ExpeditedMinDeposit gov param to 5000fct in order to make the minimum deposit for expedited proposals equal to the minimum deposit for standard proposals.
  • sets the MinInitialDepositRatio gov param to 0.52 (52%) in order to have a minimum allowed deposit threshold of 2600fct

LucaPalla95 and others added 30 commits February 17, 2025 12:50
@haryunio haryunio changed the base branch from master to v0.5.0-develop March 10, 2025 08:17
@haryunio haryunio requested review from haryunio and koofree March 10, 2025 08:17
@haryunio
Copy link
Contributor

Based on the internal discussion, we decided to apply following changes to v0.5.0 upgrade.

1. Vote Extension: Do not allow (keep current system)

  • for clarity and less complexity in governance

2) Cancelling Proposals: 0.5 returned, transfer rest to specified wallet address

  • for clear circulating supply
  • fees collected to governance cold wallet (firma1kvlelvv6u7h4jasqlpu956czt4543xqzc37h2v)
  • will decide its usage through further voting

3) Minimum Proposal Deposit At Time of Submission: 2500 FCT

  • half of voting threshold (5000 FCT)
  • ~100$ worth, reasonable amount
  • MinInitialDepositRatio to 0.5

@koofree
Copy link
Member

koofree commented Mar 13, 2025

I mentioned my reviews about this to kintsugi-tech#3.

Copy link
Member

@koofree koofree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I properly reviewed in the original PR of the kintsugi repository

Copy link
Contributor

@haryunio haryunio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haryunio haryunio merged commit 14d3024 into FirmaChain:v0.5.0-develop Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants