Skip to content

Conversation

@wjmelements
Copy link
Contributor

Reviewer @hugomrdias
This fixes a minor issue where the transaction hash wasn't logged, and some other inconsistencies in docs and examples.
It seems this used to pass a transaction object and now it just passes the hash.

Changes

  • fix onPieceAdded arg: transaction -> transactionHash

@github-project-automation github-project-automation bot moved this to 📌 Triage in FS Nov 4, 2025
@wjmelements
Copy link
Contributor Author

before the fix:

✓ [File 1/2] Piece addition transaction: undefined
✓ [File 2/2] Piece addition transaction: undefined

after:

✓ Piece addition transaction: 0xbb5d5e586075325caa750095488250640756b43c2267e04ac4230e4d1154a66f

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
synapse-dev b645ea7 Commit Preview URL

Branch Preview URL
Nov 04 2025, 11:24 PM

@rvagg
Copy link
Collaborator

rvagg commented Nov 5, 2025

I thought we changed this originally to be the transaction itself, so you could .wait() or do whatever else you wanted with it. It seems like an appropriate place to be passing a Transaction object so maybe this is an oversight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📌 Triage

Development

Successfully merging this pull request may close these issues.

3 participants