chore: biome check #386
chore: biome check #386
Conversation
|
This failure demonstrates the githook breakage on master. |
|
Change is possibly redundant with #387. |
| - name: Build | ||
| run: pnpm run build | ||
| - name: Biome Check | ||
| run: pnpm exec biome check --no-errors-on-unmatched --files-ignore-unknown=true |
There was a problem hiding this comment.
maybe should just run the precommit hook directly
There was a problem hiding this comment.
Unsure how best to set it up
https://github.com/FilOzone/synapse-sdk/actions/runs/19049562101/job/54406175172
|
i would rather not force examples to run through all our lint system to make them simple and forkable |
|
@wjmelements i think i fix this in #394 can we close ? |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | 284738a | Commit Preview URL Branch Preview URL |
Nov 05 2025, 05:16 PM |
I don't understand how that change protects the githook. Is the githook now equivalent to |
|
no, git hook only runs on staged files |
ok I see that changed in #267 |
Reviewer @hugomrdias
It is important that the precommit hook works on the
masterbranch.Changes