-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/redpanda/v1 rc #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 46 commits
fe61ae5
c0299c7
23490fe
0fed12d
10cf2d1
3d2fb43
088f4aa
8d00ea6
fe31ba7
067dce7
de84035
c9a5e42
5ef5f5b
16a65e4
1e753e9
ac4f4ce
0cde656
0799a3f
ac60492
6428156
0c7bdc2
142ae91
77b6d88
edd90a7
74595fc
97928d1
c2b16a7
0523ed4
318f43b
46c392c
3f56890
a5a9b88
9c8ef9b
dfa8fbc
e5ac3ef
5905bc0
ae992dd
01a4481
0af7e4b
9a9ac4a
e9f9c2f
73e0569
a037a69
f2e6d23
2befd01
3953a29
30398aa
d4f2eae
cf0038b
ea521d7
c744c28
637a04b
e54ef1b
bdacf0b
29c1162
ce5d328
7ae5217
1b898fe
d424e64
15f8d64
c60b43d
13f6a29
96c5ef6
ca9b143
2669472
71f3c86
4ea9d4e
dc47706
2797ae5
6a05363
334ed27
f4b60ce
ec34f23
9daed7c
be754bf
1aa0628
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I think I was maybe misunderstanding what this file is. This is about smoke testing the Regardless, it would be good to comment in this file about its purpose so there isn't confusion in the future. (And if this file is really about validating the foc-localnet code itself then I agree it belongs in this PR. Apologies about comments I made elsewhere that suggested this file doesn't belong in PR. In my mind, #8 doesn't belong in this PR. Testing to validate the work of #5 belongs in this PR...)
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
Large diffs are not rendered by default.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: seems a bit odd for this "readme" to use lowercase but README.md is all capitalized? |
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Things coming to mind when reading this:
Link to the advanced readme that defines how to do this?
Did I see correctly in slack that that only x86 macOS is supported? That seems like an important callout as I don't know if many developers with Macs have x86 anymore. Also, do we have a backlog item to improve that?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it needs an x86 machine, not particularly with macos. This all is tested against linux on x86_64. But good catch, will call it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given how large this PR is, this seems like something that could be separated out.
Also, does this actually work on github runners? It seems like there is hackery going on here to make it work. Should we just use self-hosted runners? We can get use a similar setup to what we have with Lotus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no hack here, there is a whole bunch of caching between steps that's needed to make it all run in reasonable time.
The large-ness of this PR is okay since this is still an active development non-stable repo. Breaking this apart is more effort than necessary.
In my opinion, once we have a stable V1, having smaller PRs and CI validation makes more sense.