Feat/redpanda/v1 rc #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus some additional fixes that seem to work for me
Contributor
|
@redpanda-f , @rvagg , and i are going to meet 2026-01-16 UTC about this PR and get it landed. Given @rvagg was able to get a successful localnet setup, my suggestion of conditions for merging are:
|
There was a problem hiding this comment.
Pull request overview
This PR performs a comprehensive rename of the project from "foc-localnet" to "foc-devnet" across the entire codebase. It also includes significant improvements including new retry utilities, enhanced logging, system information utilities, and updates to the default configuration.
Changes:
- Project-wide rename from "localnet" to "devnet"
- Removal of test files (build_lotus_test.rs, build_curio_test.rs) and development documentation (working.md)
- Addition of new utility modules (retry, system_info) and Docker log collection
- Chain ID updated from 1414 to 31415926
- Default configuration updates (Lotus v1.34.4-rc1, filecoin-services branch change)
- Enhanced error handling and verification with retry logic
Reviewed changes
Copilot reviewed 126 out of 127 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| working.md | Deleted development notes/documentation |
| tests/build_lotus_test.rs | Removed Lotus build integration tests |
| tests/build_curio_test.rs | Removed Curio build integration tests |
| src/version_info.rs | Updated branding from "foc-localnet" to "foc-devnet" |
| src/utils/* | New utility modules for retry logic and system info |
| src/paths.rs | Renamed all path functions from foc_localnet_* to foc_devnet_* |
| src/constants.rs | Updated constants including chain ID and container naming |
| src/config.rs | Updated default versions and repository configurations |
| src/docker/logs.rs | New Docker log collection and cleanup utilities |
| src/commands/status/* | Refactored status display with new modules |
| src/commands/start/* | Updated all start command modules with new naming |
Comments suppressed due to low confidence (2)
src/commands/start/usdfc_funding/funding_operations.rs:1
- The --rm flag is removed but the code still includes it on line 62, then adds --name on line 63. This appears to be an editing error - the --rm should be removed consistently as indicated in the diff.
src/commands/start/synapse_test_e2e/synapse_test_step.rs:1 - The CLI flag value changed from 'localnet' to 'devnet', but verify that the synapse-sdk's post-deploy-setup.js script accepts 'devnet' as a valid network parameter. This could cause runtime failures if the script doesn't recognize this value.
BigLep
added a commit
that referenced
this pull request
Jan 16, 2026
- Add command prerequisites (build after init, start after init and build) - Add 'How defaults work' section explaining config generation - Update Run ID format to ISO8601 (YYYYMMDDTHHMM_RandomName) - Improve Step Context documentation with cross-references - Update Portainer section formatting and add documentation link - Clarify container descriptions (shared database, dynamic ports) - Add version strategy section for repository management - Simplify configuration sharing from 3-step to 2-step process - Normalize timing claims to percentages (~40% improvement) - Update directory structure examples to use ISO8601 format Addresses review feedback from @BigLep in PR #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.