Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Adds support to notifications #7

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

WIP: Adds support to notifications #7

wants to merge 6 commits into from

Conversation

Naraujo13
Copy link
Member

What does this pull request aim to achieve? 💯

Adds support to notifications

What this PR does?

  • Adds collection notifications to store conversations
  • Updates the scripts, docs, and GitHub page

Feature

Desktop

image

Collections

The following collections were modified:

Notifications

Notifications Collection




Discussion Topics

  • What happens when the user clicks the notification? Is the user sent to his post showing the exact comment/action that triggered the notification? This would influence how we design the references to allow the desired behavior
  • What happens if a user deletes a post or comment that affects the notification? This would change our update/sync policy
  • What kind of control does the user have on what is notified or not? This will probably shape how we model notifications permissions on the user collection
  • What kind of notifications we have? Only push and email? Can we keep track of who read the notifications? Is that information useful?

@Naraujo13
Add private message support
99941ba 
- Add messages collection
- Add threads collection
@Naraujo13
Update diagram images for README
01cb471
@Naraujo13
Update github page
cd42854
@Naraujo13
Updates README
7aa19eb
@Naraujo13
Update private messages model
1d9326e 
- Replace embedded author doc for simple reference in messages to optimize space (it will always be used with the thread, that already has that embedding)
- Remove location from the author doc in the threads collection
- Update relationships names in documentation
@Naraujo13
Add support for notifications
3936b86
@Naraujo13 Naraujo13 added the enhancement New feature or request label Sep 13, 2020
@Naraujo13 Naraujo13 self-assigned this Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaofnds joaofnds Awaiting requested review from joaofnds

@joshmorel joshmorel Awaiting requested review from joshmorel

Assignees

@Naraujo13 Naraujo13

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Naraujo13