Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for private messages #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add support for private messages #6

wants to merge 5 commits into from

Conversation

Naraujo13
Copy link
Member

What does this pull request aim to achieve? 💯

Adds support to private messages

What this PR does?

  • Adds collection threads to store conversations
  • Updates the scripts, docs, and GitHub page
  • Adds collection messages to store the conversation's messages

Feature

Desktop

Desktop

Mobile

image

Collections

The following collections were modified:

Threads

Threads Collection




Messages

Messages Collection

@Naraujo13 Naraujo13 added the enhancement New feature or request label Sep 8, 2020
@Naraujo13 Naraujo13 requested a review from joshmorel September 8, 2020 01:43
@Naraujo13 Naraujo13 self-assigned this Sep 8, 2020
@Naraujo13
Copy link
Member Author

Naraujo13 commented Sep 8, 2020 •
edited
Loading

@joshmorel I don't know Luis' or Kevin's username here, so please add then as reviewers also 😅

@lmpeixoto
Copy link

@Naraujo13 I think you've done a great job. The only thing I'd change is the location, as @joshmorel said. Don't know if you'd like to add something about that?!

@Naraujo13
Copy link
Member Author

Naraujo13 commented Sep 11, 2020 •
edited
Loading

@Naraujo13 I think you've done a great job. The only thing I'd change is the location, as @joshmorel said. Don't know if you'd like to add something about that?!

As mentioned in the model PR, I agree about removing the location ref.

I'm also questioning the need for an embedded ref for the author at all in the messages collection since that will always be used with a thread that already has it. Removing that might save us space and all the sync hassle.
What do you guys think?

@Naraujo13
Update private messages model
1d9326e 
- Replace embedded author doc for simple reference in messages to optimize space (it will always be used with the thread, that already has that embedding)
- Remove location from the author doc in the threads collection
- Update relationships names in documentation
@Naraujo13 Naraujo13 requested a review from joaofnds September 13, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmorel joshmorel Awaiting requested review from joshmorel

@joaofnds joaofnds Awaiting requested review from joaofnds

Assignees

@Naraujo13 Naraujo13

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naraujo13 @lmpeixoto