prefer .expect instead of unwrapping into a panic #87
Conversation
Additionally run the sqlx::migrate macro with no arguments since it defaults to `../migrations` (which is what it was before)
|
Please fix the checks. |
neither of them seem very fixable to me/related as a result of this PR, potentially a seperate PR could be created to fix these checks. with this project not having been touched in a long time im pretty sure many are related to breaking changes (since the server uses nightly.) one example is |
|
They’re still worth fixing. |
|
Since the checks originate in an area of the code that is not being changed here, I think it is fine. I am approving, but I do want to wait for @tazz4843 to merge. |
|
I take it back, this needs to go onto the dev branch to avoid conflicts down the line. |
just a heads up, develop is 9 commits behind master although im sure you can just merge |
|
commit is now targeted to develop |
|
The missing commits appear to be merge commits, so I am not concerned. Approving now. |
Additionally run the sqlx::migrate macro with no arguments since it defaults to
../migrations(which is what it was before)