Skip to content
This repository has been archived by the owner on Nov 23, 2022. It is now read-only.

Beginnings of password reset #80

Merged
merged 9 commits into from
Dec 20, 2021
Merged

Beginnings of password reset #80

merged 9 commits into from
Dec 20, 2021

Conversation

randomairborne
Copy link
Contributor

This needs to be made more robust, please review it.

Signed-off-by: valkyrie_pilot [email protected]

Signed-off-by: valkyrie_pilot <[email protected]>
@hydrostaticcog
Copy link
Member

Is this designed to be a Forgot my password? or a way to change your password?

@randomairborne
Copy link
Contributor Author

Forgot my password. I can add another endpoint to simply check if you are who you are and then change your password, that's much simpler

Copy link
Member

@hydrostaticcog hydrostaticcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design is flawed. User should verify their intent via email, then change their password

@tazz4843
Copy link
Member

I can add another endpoint to simply check if you are who you are and then change your password, that's much simpler

That already exists under edit_user, so this password reset would just be for forgot password yes.

Design is flawed. User should verify their intent via email, then change their password

The two of us talked about it in DMs, and she brought up some good points about it. This design is a bit weird yes, but I agreed it's good.

@randomairborne
Copy link
Contributor Author

Basically, we don't want to host a browser-oriented webpage on the API. Nothing with, say, an interface for changing your password. I do plan to remove the authorization requirement, so this can work as a forgot my password.

@hydrostaticcog hydrostaticcog added the enhancement New feature or request label Dec 19, 2021
Copy link
Member

@hydrostaticcog hydrostaticcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended on endeavourOS Linux x86-64 (kernel 5.14.12)

@tazz4843 tazz4843 merged commit 8a0ca96 into FerrisChat:develop Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API enhancement New feature or request
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants