-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
Signed-off-by: valkyrie_pilot <[email protected]>
Is this designed to be a |
Forgot my password. I can add another endpoint to simply check if you are who you are and then change your password, that's much simpler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design is flawed. User should verify their intent via email, then change their password
That already exists under edit_user, so this password reset would just be for forgot password yes.
The two of us talked about it in DMs, and she brought up some good points about it. This design is a bit weird yes, but I agreed it's good. |
Co-authored-by: 0/0 <[email protected]>
Co-authored-by: 0/0 <[email protected]>
Basically, we don't want to host a browser-oriented webpage on the API. Nothing with, say, an interface for changing your password. I do plan to remove the authorization requirement, so this can work as a forgot my password. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as intended on endeavourOS Linux x86-64 (kernel 5.14.12)
This needs to be made more robust, please review it.
Signed-off-by: valkyrie_pilot [email protected]