Skip to content
This repository has been archived by the owner on Nov 23, 2022. It is now read-only.

Implement fetch bots by user #71

Merged
merged 14 commits into from
Nov 24, 2021
Merged

Implement fetch bots by user #71

merged 14 commits into from
Nov 24, 2021

Conversation

Cryptex-github
Copy link
Contributor

No description provided.

@Cryptex-github Cryptex-github added enhancement New feature or request API labels Nov 22, 2021
@Cryptex-github Cryptex-github requested a review from a team as a code owner November 22, 2021 20:55
@hydrostaticcog
Copy link
Member

you forgot to add the new file

@hydrostaticcog
Copy link
Member

also fmt

hydrostaticcog
hydrostaticcog previously approved these changes Nov 22, 2021
View reviewed changes
@hydrostaticcog
Copy link
Member

Awaiting @tazz4843 for merge

tazz4843
tazz4843 previously approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@tazz4843 tazz4843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this would be better as a single query, but this works too.

@tazz4843
Copy link
Member

need the three failing builds to work before merge

randomairborne
randomairborne previously approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@randomairborne randomairborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing here stands out to me as objectionable.

tazz4843
tazz4843 previously approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@tazz4843 tazz4843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but could be made more rusty

@randomairborne randomairborne dismissed stale reviews from tazz4843 and themself via e930c8f November 24, 2021 03:37
@tazz4843 tazz4843 merged commit 11f67ce into FerrisChat:develop Nov 24, 2021
randomairborne
randomairborne approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@randomairborne randomairborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was one semicolon and a return

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tazz4843 tazz4843 tazz4843 approved these changes

@randomairborne randomairborne randomairborne approved these changes

@hydrostaticcog hydrostaticcog hydrostaticcog left review comments

Assignees
No one assigned
Labels
API enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cryptex-github @hydrostaticcog @tazz4843 @randomairborne