Fix scala 2.13 compile issue in new test #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjfanning I think it'd probably make sense to give you more access -- just need to check with @mbknor and @nbauernfeind to make sure (i..e how to keep everyone in sync) |
|
All enabled tests in master-branch runs fine on my machine for all scala-versions. I have no problems with @pjfanning getting push-permissions to the repo - if that's the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new test that I added in #420 does not compile in scala 2.13 (apologies).
This PR removes the import that fails.
The scala 2.11 and scala 2.10 builds in travis are also failing but the tests pass for me locally for both of these scala versions.