Skip to content

Attempt to fix JsonCreator related bugs. #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2016

Conversation

nbauernfeind
Copy link
Member

I believe that this should fix #229, #230, and #231. I was able to conclude that the test provided with 230 now passes.

I don't really understand why the test won't fail unless it's running inside of intellij.

@mbknor
Copy link
Member

mbknor commented Mar 1, 2016

I'll test the "attempt to fix". Should I use 2.6.6-SNAPSHOT? Is this deployed to sonatype snapshot repo?

About "I don't really understand why the test won't fail unless it's running inside of intellij":
I do not think it is related to intelliJ, but Java 8.

@nbauernfeind
Copy link
Member Author

2.6.5, 2.7.2 or either of the snapshots should work.

I know it seems like it's Java8 related but it's not. Even when I'm running in IntelliJ on 1.6 (i.e. it's clearly using /Library/Java/JavaVirtualMachines/1.6.0_65-b14-462.jdk/Contents/Home/bin/java) it is reproduced. No matter how I try to get tests to run from within SBT it does not fail this test (I've even removed the jvm target restrictions for tests only). However, if I run all tests in IntelliJ using JDK6 (or JDK8) only the CreatorTest was failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants