Fix #385: add module-info.class using Moditect plugin#393
Conversation
|
@GedMarc something like this? Seems to generate the module-info in jar. |
|
Looks good - now everything but the tears.... Man this is going to have an impact on Kotlin I just know it, I am so sketchy doing this. @dinomite I know of one bug so far where resources on JDK 12 and higher can't get called, this is due to a change where empty paths are classified packages, and accessing them requires an opens clause to the calling module, But these small undocumented (f-sakes) changes have a big impact, I still don't know how the JDK 13 change where service loaders not longer reference META-INF/services and only the module-info files (using provides clause) will do here. Especially since a provides clause can only be specified in module-info (not even command line) and only from the module containing the class being provided... This may be a tall order, but is it possible to have @dinomite test this before even pulling it in, this could be really dangerous doing it before kotlin actually supports it. I've found in places making one module strictly defined makes the compiler define them all strictly |
|
One thing that may help is that I still plan on releasing 2.12.0-rc2 first, give some time to test, allow changes (like reverting inclusion if need be) and only then 2.12.0 is released. |
|
Will go ahead, merge; if there are issues we can just remove/comment out ref to moditect from |
As per title, this is for #385, add generation of
module-info.classusing Moditect plugin, same as almost every other Jackson module.