Skip to content

Using Stream Builder to deserialization of int[] #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 29, 2024
Merged

Using Stream Builder to deserialization of int[] #125

merged 12 commits into from
Feb 29, 2024

Conversation

Shounaks
Copy link
Contributor

Issue: #7
we can use IntStream.Builder and iteratively add tokens. I don't know if its wasteful or not... 😥

@Shounaks Shounaks marked this pull request as ready for review February 25, 2024 08:40
cowtowncoder added a commit that referenced this pull request Feb 26, 2024
@cowtowncoder
Minor clean up from #125
b565366
Shounaks pushed a commit to Shounaks/jackson-jr that referenced this pull request Feb 27, 2024
@cowtowncoder @Shounaks
Minor clean up from FasterXML#125
0c6eee9
@cowtowncoder
Copy link
Member

Ok, changed decoding logic to avoid StackOverflowException, made it bit stricter.
I think the failing test is wrong in that it has "one too many levels"; where int is expected we should not accept Arrays, Objects etc.

@cowtowncoder cowtowncoder merged commit 160a072 into FasterXML:2.17 Feb 29, 2024
@Shounaks Shounaks deleted the 2.17-int-deserialization branch March 1, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shounaks @cowtowncoder