Skip to content

Try to fix #160 (OSGi dep problem wrt Guava) #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Try to fix #160 (OSGi dep problem wrt Guava) #161

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd70a94
Try to fix #160 (OSGi dep problem wrt Guava)
cowtowncoder Sep 9, 2024
df9c15c
Fix the recursive def problem
cowtowncoder Sep 9, 2024
d55d503
Changes as suggested by reporter of the issue
cowtowncoder Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion guava/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,13 @@ Guava (https://github.com/google/guava) types (currently mostly just collection
<!-- 28-Feb-2023, tatu: 2.15 raises baseline from 21.x to 23.x -->
<!-- 01-May-2023, tatu: 2.16 raises baseline from 23.x to 25.x -->
<version.guava>25.1-jre</version.guava>
<version.guava.osgi-base>25.1</version.guava.osgi-base>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #160 (comment) the exact version that is used for exporting the required package in guava library is 25.1.0. Thus using this exact version string we should be safe.


<javac.src.version>1.8</javac.src.version>
<javac.target.version>1.8</javac.target.version>

<!-- 31-Jul-2020, tatu: remove upper limit for Jackson 2.12; tested up to 30.x -->
<version.guava.osgi>[${version.guava}.0,99)</version.guava.osgi>
<version.guava.osgi>[${version.guava.osgi-base}, 99)</version.guava.osgi>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space has been added before 99- I am not sure if this is allowed in an OSGi version range selector. I would recommend to omit the space.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that was unintentional -- I suspect it should be ok but better safe than sorry so will remove


<!-- Generate PackageVersion.java into this directory. -->
<packageVersion.dir>com/fasterxml/jackson/datatype/guava</packageVersion.dir>
Expand Down
2 changes: 2 additions & 0 deletions release-notes/VERSION-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ Active Maintainers:

2.18.0 (not yet released)

#160: (guava) Defect guava OSGi dependency version specified?
(reported by @jpstotz)
- HPPC dependency upgraded to 0.9.1 (from 0.8.2)

2.17.2 (05-Jul-2024)
Expand Down
Loading