Skip to content

Fix issue #34: OSGI import statement version range management #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2014

Conversation

rgilles
Copy link
Contributor

@rgilles rgilles commented Sep 3, 2014

Fix issue #34:

  • change the osgi.versionpolicy to generate version range import from a given major.minor.micro to the next major. By the way this is the default bnd lib behavior.
    • remove extract version property in the export statement as it is just the default bnd lib behavior and therefore does not add value except make it explicit
    • remove the osgi.import properties has the default bnd lib behavior provide exactly the same and also ensure that the import statement will be always in sync with the dependency usage.

  * change the `osgi.versionpolicy` to generate version range import from a given major.minor.micro to the next major. By the way this is the default bnd lib behavior.
  * remove extract version property in the export statement as it is just the default bnd lib behavior and therefore does not add value except make it explicit
   * remove the `osgi.import` properties has the default bnd lib behavior provide exactly the same and also ensure that the import statement will be always in sync with the dependency usage.
@rgilles
Copy link
Contributor Author

rgilles commented Sep 3, 2014

After a quite review of the overall maven-bundle-plugin I think you should upgrade and maybe see if you can use default behaviors instead of some overridden ones.
I can also help you to create a project to run integration on osgi frameworks if you want.

@cowtowncoder
Copy link
Member

Current bundle plug-in version seems to be 2.3.7. There is no particular reason for using that, although I think there was an issue with one of nearby versions (2.3.6 maybe?) in the past.
Latest is 2.5.3.
Plugin baseline versions are updated via parent poms although local override is probably possible as necessary.

Integration project would be nice if it could automatically detect breakages in imports/exports. I think auto-generation makes sense; only export statements may need bit more thought to hide private/implementation details.

cowtowncoder added a commit that referenced this pull request Sep 4, 2014
Fix issue #34: OSGI import statement version range management
@cowtowncoder cowtowncoder merged commit d3136f5 into FasterXML:master Sep 4, 2014
@cowtowncoder
Copy link
Member

I'll be upgrading maven plugins via parent pom, for 2.5. Looks like many can be upgraded, but two proved problematic:

  • release plugin 2.5 breaks ... release, due to some git/ssh issue. Has to stay 2.4.2
  • gpg plugin 2.5 similarly broken (asks for password twice, prints warnings), remain at 2.4.

but I don't know if there'd be any benefits from upgrade; plus versions are quite close to most recent even as is.

But bundle plugin upgrade to 2.5.3 (from 2.3.7) appears to work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants