Fix #98 timezone lost for @JsonFormat
#167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
commented
May 4, 2025
src/test/java/com/fasterxml/jackson/datatype/joda/ser/JsonFormatTimeZoneWithPattern98Test.java
Outdated
Show resolved
Hide resolved
JooHyukKim
commented
May 4, 2025
Comment on lines
+20
to
+48
| static class Wrapper3Z<T> { | ||
| @JsonFormat( | ||
| shape = JsonFormat.Shape.STRING, | ||
| pattern = "yyyy-MM-dd'T'HH:mm:ss.SSS ZZZ", | ||
| timezone = "Europe/Budapest" // +01:00 in winter | ||
| ) | ||
| public T value; | ||
| Wrapper3Z(T v) { value = v; } | ||
| } | ||
|
|
||
| static class Wrapper2Z<T> { | ||
| @JsonFormat( | ||
| shape = JsonFormat.Shape.STRING, | ||
| pattern = "yyyy-MM-dd'T'HH:mm:ss.SSS ZZ", | ||
| timezone = "Europe/Budapest" | ||
| ) | ||
| public T value; | ||
| Wrapper2Z(T v) { value = v; } | ||
| } | ||
|
|
||
| static class Wrapper1Z<T> { | ||
| @JsonFormat( | ||
| shape = JsonFormat.Shape.STRING, | ||
| pattern = "yyyy-MM-dd'T'HH:mm:ss.SSS Z", | ||
| timezone = "Europe/Budapest" // +01:00 in winter | ||
| ) | ||
| public T value; | ||
| Wrapper1Z(T v) { value = v; } | ||
| } |
There was a problem hiding this comment.
Formatting difference reference from joda doc
cowtowncoder
approved these changes
May 6, 2025
|
I assume this was meant to target |
cowtowncoder
approved these changes
May 6, 2025
My intial thought was 2.20, but 2.19 seems also reasonable 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98