-
-
Notifications
You must be signed in to change notification settings - Fork 150
support overriding the codePointLimit #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think that although in many ways it's good to hide details of the underlying implementation, in this case benefits probably outweigh drawbacks. One particularly compelling reason here is this: as I understand, this new setting is only available in SnakeYAML 1.32. If so, we either have to:
But if we only expose functionality for interacting with If it wasn't for this compatibility issue, I might suggest doing both (simple |
@cowtowncoder I have reworked to this to allow users to set the LoaderOptions instance explicitly |
Looks good, will merge. One thing that might make sense -- and I can try to add it -- would be an example of how to expand maximum size limit, on YAML module's README. |
@pjfanning Was able to merge to @asomov Do you know if I missed something obvious (setting is maybe somewhere else), or if omission is intentional? |
@cowtowncoder it does not have it yet. But it will get it soon |
@asomov Excellent: no super hurry as this only affects Jackson 3.0.0-SNAPSHOT, not yet released. So just let us know when it is added. Thank you! |
@cowtowncoder SnakeYAML Engine version 2.5 with the support for codePointLimit is released |
Thank you @asomov ! I enabled test for this in /cc @pjfanning |
#337
Work in progress. Will add tests before merging but would like to open a discussion on the APIs.
Another option is to support setting a snakeyaml LoaderOptions instance on YamlFactoryBuilder, so users would have full control. There are other settings in LoaderOptions that might be useful to support. https://www.javadoc.io/doc/org.yaml/snakeyaml/latest/org/yaml/snakeyaml/LoaderOptions.html