Fix #146: Underscores in numbers

[conor-ward]

This PR fixes #146 for yaml. The test code below from that issue now passes but I'm unsure on where this test should exist.

    private static class LongHolder {
        private Long v;

        public Long getV() {
            return v;
        }

        public void setV(Long v) {
            this.v = v;
        }
    }

    private static class IntHolder {
        private Integer v;

        public Integer getV() {
            return v;
        }

        public void setV(Integer v) {
            this.v = v;
        }
    }

    @Test
    public void testYamlUnderscores() throws IOException {
        ObjectMapper mapper = new ObjectMapper(new YAMLFactory());
        mapper.readValue("v: 1000000", IntHolder.class); // ok
        mapper.readValue("v: 1_000_000", IntHolder.class); // ok
        mapper.readValue("v: 1000000", LongHolder.class); // ok

        // throws: com.fasterxml.jackson.databind.JsonMappingException: For input string: "1_000_000"
        mapper.readValue("v: 1_000_000", LongHolder.class);
    }

For the fix, it looks like the original fix for #65 here missed using the _cleanedTextValue in the two places in the PR

[kupci]

I'm unsure on where this test should exist.
What about StreamingParseTest (based on previous work done for this fix)?

jackson-dataformats-text/yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/deser/StreamingParseTest.java

Line 179 in 0a59a70

public void /*test*/ IntParsingUnderscoresSm() throws Exception

[cowtowncoder]

Yes, StreamingParseTest seems reasonable to me.

[cowtowncoder]

@conor-ward Looks good; I can manually add the test method, or you can change PR; either way is fine.

But one thing we'll need (if not asked for it yet) is CLA. It can be found here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print it, fill & sign, scan/photo, email to info at fasterxml dot com.
This only needs to be done once, before the first contribution, and then it's good for any number of future contributions.

Thank you again for providing the fix!

[conor-ward]

Took the test from failing directory on master here and put it in StreamingParseTest
Will send CLA on also

[cowtowncoder]

Sounds good!