-
-
Notifications
You must be signed in to change notification settings - Fork 141
[Avro] write enums as string #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cowtowncoder
merged 7 commits into
FasterXML:2.18
from
MichalFoksa:feature/2.18/494-write_enums_as_string
Jun 7, 2024
Merged
[Avro] write enums as string #496
cowtowncoder
merged 7 commits into
FasterXML:2.18
from
MichalFoksa:feature/2.18/494-write_enums_as_string
Jun 7, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vro string mapping at schema generation.
Thank you @MichalFoksa ! PR very welcome. I hope to check this out soon -- possibly not today but in next couple of days. |
avro/src/main/java/com/fasterxml/jackson/dataformat/avro/schema/AvroSchemaGenerator.java
Show resolved
Hide resolved
cowtowncoder
approved these changes
Jun 7, 2024
@MichalFoksa I think this is ready so will merge; made some minor cosmetic changes but nothing major. Thank you once again for contributing this! |
@cowtowncoder You are welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New switch added
enableWriteEnumAsString()
to enable Java enum to Avro string mapping at schema generation.Fixes #494