Skip to content

Improve error message in AvroAliasTest #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Improve error message in AvroAliasTest #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions ...rc/test/java/com/fasterxml/jackson/dataformat/avro/interop/annotations/AvroAliasTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public void testAliasedRecordForwardsCompatible() throws IOException {
SchemaCompatibility.SchemaPairCompatibility compatibility =
SchemaCompatibility.checkReaderWriterCompatibility(newSchema, oldSchema);
//
assertThat(compatibility.getType()).isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
checkSchemaIsCompatible(compatibility);
}

@Test
Expand All @@ -88,7 +88,7 @@ public void testAliasedRecordForwardsCompatibleSameNamespace() throws IOExceptio
SchemaCompatibility.SchemaPairCompatibility compatibility =
SchemaCompatibility.checkReaderWriterCompatibility(newSchema, oldSchema);
//
assertThat(compatibility.getType()).isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
checkSchemaIsCompatible(compatibility);
}

@Test
Expand All @@ -110,7 +110,7 @@ public void testAliasedEnumForwardsCompatible() throws IOException {
SchemaCompatibility.SchemaPairCompatibility compatibility =
SchemaCompatibility.checkReaderWriterCompatibility(newSchema, oldSchema);
//
assertThat(compatibility.getType()).isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
checkSchemaIsCompatible(compatibility);
}

@Test
Expand All @@ -134,8 +134,14 @@ public void testAliasedEnumForwardsAndBackwardsCompatible() throws IOException {
SchemaCompatibility.SchemaPairCompatibility forwardsCompatibility =
SchemaCompatibility.checkReaderWriterCompatibility(newSchema, oldSchema);
//
assertThat(backwardsCompatibility.getType()).isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
assertThat(forwardsCompatibility.getType()).isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
checkSchemaIsCompatible(backwardsCompatibility);
checkSchemaIsCompatible(forwardsCompatibility);
}

private void checkSchemaIsCompatible(SchemaCompatibility.SchemaPairCompatibility compatibility) {
assertThat(compatibility.getType())
.withFailMessage("Expected schema to be compatible but was not. Reason:\n%s", compatibility.getDescription())
.isEqualTo(SchemaCompatibility.SchemaCompatibilityType.COMPATIBLE);
}

}