Add @AvroNamespace annotation to override Avro type namespace #324
Conversation
MichalFoksa
changed the title
| * Annotation allows to override default Avro type namespace value. | ||
| * Default value is Java package name. | ||
| */ | ||
| @Target(ElementType.TYPE) |
There was a problem hiding this comment.
To allow "annotation bundle" usage may also want to add ElementType.ANNOTATION_TYPE
There was a problem hiding this comment.
Right, good idea.
ElementType.ANNOTATION_TYPE added to allow "annotation bundle" usage.
|
but one thing is that this cannot go in 2.13 patch since it is both slightly backwards-incompatible (changes method signature of the helper method) and (more importantly) adds a new annotation type. EDIT: Removed a former comment wrt Ion -- for some reason, got things mixed up. |
|
PR is now rebased on 2.14. |
|
Thank you @MichalFoksa! Also, apologies for nonsensical comment wrt Ion & Amazon developers. This is for Avro, but somehow I managed to get things fixed. I'll try to get this reviewed soon, |
…space. Current namespace value is Java package name. This annotation allows to override its name.
|
No problem, really - I understand :). I have updated my commit - just reorganized imports in AvroSchemaHelper. Moved imports from |
|
Will merge: will also change package name from "...avro.annotations" to "...avro.annotation", just to be consistent with other Jackson packages (jackson-annotations, jackson-databind, jackson-dataformat-xml). |
cowtowncoder
changed the title
|
Thank you again @MichalFoksa for contributing this! It will go in 2.14.0 once we get there. |
|
@cowtowncoder |
New
AvroNamespaceannotation to override default Avro type namespace.Simple way how to override default Avro namespace value with a new, custom, annotation.
This solves #310.
Is the new annotation package OK?