-
-
Notifications
You must be signed in to change notification settings - Fork 141
Fix IonValueDeserializer's getNullValue when bean is missing a property #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IonValueDeserializer's getNullValue when bean is missing a property #320
Conversation
… a missing property
…ats-binary into fix_getNullValue_MissingProperty
@mcliedtke Can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, one small comment on including an additional test assertion
ion/src/test/java/com/fasterxml/jackson/dataformat/ion/ionvalue/IonValueDeserializerTest.java
Show resolved
Hide resolved
Can you also comment on what branches you believe this change to be added to. Are you targeting for updating 2.13? |
@mcliedtke good catch on missing check. I have added the extra assertion. |
LGTM, I think these changes can be merged. Given the nature of the change, I think merging to 2.13 is pretty safe. @cowtowncoder do you want to handle the merge itself? |
@cowtowncoder or @mcliedtke |
Following up with this merge request @cowtowncoder @mcliedtke |
Ok, I am back from my vacation. @atokuzAmzn If you want this merged against 2.13, please rebase or recreate. |
This is my first time working with github. I changed the base of this PR but I am not sure if this is what you wanted @cowtowncoder. If needed I can recreate a new PR based on 2.13 |
@atokuzAmzn Alas, no: this would merge back all changes from 2.14 -- and not just ones you are making -- so that wouldn't work. I am not 100% sure what'd be the easiest way to change the base for existing PR. Maybe others can suggest something? But it may be easier to simply create a new PR, if that works? |
I created a new PR based on 2.13 here : #322 |
This PR aims to resolve the issue #317
Changes: