Add copy-constructor for MappingIterator
#5069
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k163377
commented
Apr 5, 2025
Comment on lines
+165
to
+168
| /** | ||
| * Copy-constructor that sub-classes can use when creating new instances | ||
| * by fluent-style construction | ||
| */ |
There was a problem hiding this comment.
I refer to the following comment
cowtowncoder
reviewed
Apr 5, 2025
| @@ -162,6 +162,14 @@ protected MappingIterator(JavaType type, JsonParser p, DeserializationContext ct | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Copy-constructor that sub-classes can use when creating new instances | |||
| * by fluent-style construction | |||
There was a problem hiding this comment.
We always want @since annotation: I can add it.
cowtowncoder
approved these changes
Apr 5, 2025
cowtowncoder
changed the title
MappingIterator
cowtowncoder
added a commit
that referenced
this pull request
Apr 5, 2025
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently trying to add a check process for
MappingIterator.nextValue(to fix FasterXML/jackson-module-kotlin#399).https://github.com/FasterXML/jackson-module-kotlin/blob/1cf821da365093a23b2e7c21bf97d17ecc4ee112/src/main/kotlin/com/fasterxml/jackson/module/kotlin/Extensions.kt#L54
A copy-constructor would be useful for this.
Could you please consider if this code could be merged?