RFE-4650: Single string value primitive array deserialization improvement #5022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive when ACCEPT_SINGLE_VALUE_AS_ARRAY is enabled.
| @@ -214,7 +214,7 @@ public T deserialize(JsonParser p, DeserializationContext ctxt, T existing) thro | |||
| protected T handleNonArray(JsonParser p, DeserializationContext ctxt) throws IOException | |||
| { | |||
| // Empty String can become null... | |||
| if (p.hasToken(JsonToken.VALUE_STRING)) { | |||
| if (p.hasToken(JsonToken.VALUE_STRING) && p.getText().isEmpty()) { | |||
| return _deserializeFromString(p, ctxt); | |||
There was a problem hiding this comment.
@eeren-bm Have a look at this method in StdDeserializer... By-passing it will skip lots of potentially necessary processing, including CoercionConfig settings.
But I think we can get this to work by bit more re-factoring. Let me see if I can change it a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #4650)
PrimitiveArrayDeserializers to deal with single value primitive when ACCEPT_SINGLE_VALUE_AS_ARRAY is enabled.