Skip to content

Conversation

@JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Feb 15, 2025

resolves #4915

*
* @return Result of conversion
*/
protected T convertValue(Object delegateValue, DeserializationContext ctxt) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note: I think it makes sense to change the order of parameters -- even tho we usually append new ones, in this case context should come before value.
I can change the ordering.

Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cowtowncoder cowtowncoder merged commit b5e54e5 into FasterXML:2.19 Mar 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot access attributes from Converter

2 participants