Doc : Resolve #4570 explain more on ObjectMapper.canDeserialize()/ObjectMapper.canSerialize() deprecation
#4826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anSerialize()` deprecation
JooHyukKim
changed the title
ObjectMapper.canDeserialize()/ObjectMapper.canSerialize() deprecation
cowtowncoder
reviewed
Dec 3, 2024
| @@ -3637,6 +3637,8 @@ public <T extends JsonNode> T valueToTree(Object fromValue) | |||
| * serializable) | |||
| * | |||
| * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0 | |||
| * It is recommended to try directly testing de/serialization using actual JSON inputs and outputs | |||
There was a problem hiding this comment.
Instead of "de/serialization" let's spell out either "serialization" or "deserialization" depending on which one method relates to (so "serialization" in this case).
There was a problem hiding this comment.
Yeah, let's do that! (done)
cowtowncoder
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4570
Let's tell users something more than "use discouraged".