Allow using @JsonPropertyOrder with any-property (@JsonAnyGetter) #4775
Conversation
src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java
Show resolved
Hide resolved
|
@JooHyukKim Ok, I am trying to understand the PR and I think what is needed is high-level description of logical change(s) being made. I think I have an idea but since you understand the intent, could you write a description of changes (more on "why" things changed than "what"). |
Will do! 👍🏼 |
| // In 2.19, Fails Actual | ||
| // : {"value":{"firstProperty":"first","secondProperties":"second","forthProperty":"forth","third_A":"third_A","third_B":"third_B"}} | ||
| // Getting better, after #4775 in 2.19, fails Actual | ||
| // : {"value":["first","second",{"third_A":"third_A","third_B":"third_B"},"forth"]} |
There was a problem hiding this comment.
@cowtowncoder this what I meant in above comment
@cowtowncoder updated PR description as suggested 👍🏼. While writing the PR description, I was reminded of what we did with |
|
Looks good, will merge. May be tricky to merge to master but... hope it's ok. |
@cowtowncoder Lemme me know if anything! |
|
|
||
| final ObjectMapper MAPPER = newJsonMapper(); | ||
|
|
||
| @JacksonTestFailureExpected |
There was a problem hiding this comment.
TODO: Move to test dir, out of tofix
There was a problem hiding this comment.
Is the test then not failing or... ?
There was a problem hiding this comment.
Since the test is expected behavior, we may move to tests dir.
There was a problem hiding this comment.
Filed #4965 accordingly.
Merging went just fine! Yay. |
|
@JooHyukKim Ouch. One problem: XML module broke https://github.com/FasterXML/jackson-dataformat-xml/actions/runs/13222535686/job/36909393854 since it refer to And on short term that also breaks Kotlin module's CI (since it -- unfortunately -- depends on XML module for tests (IMO, shouldn't)). |
Description
This PR tries to achieve functionality as per title by making any-getter a
BeanPropertyWriter(subtype).Previously any-getter property has been handled as standalone. Being standalone meaning it need individual handling for all cases, unlike other sub-classes of
BeanPropertyWriternaturally gets bunch of property handling applied.Notes
Same as #4396, but rebased against 2.19 version. This PR resolves... #4388 and part of #2592 AnyGetter with JsonInclude + JsonFilter combo