Skip to content

Implement new BeanPropertyDefinition.getAliases() method #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

JooHyukKim
Copy link
Member

as per #4335 (comment)

blocks #4335

@cowtowncoder
Copy link
Member

Realized that name should be "findAliases()" to follow convention; changed, will merge after CI passes.

*
* @since 2.17
*/
public List<PropertyName> findAliases() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to implement here for backwards compatibility (in case anything else extends base type)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True... good catch

@JooHyukKim
Copy link
Member Author

Realized that name should be "findAliases()" to follow convention; changed, will merge after CI passes.

Thanks!

@cowtowncoder cowtowncoder merged commit a26c015 into FasterXML:2.17 Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants