-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Preserve the original component type in merging to the array #4117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It would be nice if this fix will be backported to 2.14 and 2.15 also. |
Looks good, thank you for contributing this @yurkom ! One thing before merging (and considering where to backport): unless we have a CLA from you for earlier PRs (if so, please LMK), we'd need one now: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf (this is only needed once before the first contribution to any Jackson project) and is usually done by printing doc, filling & signing, scan/photo, email to Once this is received I can merge PR. As to backporting, since this looks quite safe it could go in 2.15 for sure (for which there will probably eventually be a patch release); I could merge it in 2.14 but it's not clear if or when a patch might be released. |
Wrt backporting, how about we start a new PR based on 2.14 or 2.15 (whichever we agree on)? So we can just forward-merge naturally. |
Yes, re-creating PR to target 2.14 would be nice. But I can alternatively just cherry-pick this one too if that's too much hassle. I can merge this in 2 days (right now can't commit but can comment :) ) |
If it's not too much hassle for you @yurkom, following steps will get things done 👍🏼👍🏼
|
Thank you; apologies for not mentioning that it is enough to create just one (oldest branch, 2.14) and we can merge forward. I will merge close this issue and leave 2.14 pr; hope to merge some time tomorrow or day after (right now don't have commit access due traveling) |
Replaced by #4121 |
It fixes an exception: