Skip to content

Use box-impl function as factory for kotlin value class #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use box-impl function as factory for kotlin value class #4067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/main/java/com/fasterxml/jackson/databind/introspect/AnnotatedCreatorCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,18 @@ private List<AnnotatedMethod> _findPotentialFactories(TypeFactory typeFactory,

private static boolean _isIncludableFactoryMethod(Method m)
{
return Modifier.isStatic(m.getModifiers())
// 09-Nov-2020, ckozak: Avoid considering synthetic methods such as
// lambdas used within methods because they're not relevant.
&& !m.isSynthetic();
if (!Modifier.isStatic(m.getModifiers())) {
return false;
}

boolean isKotlinValueClassFactory = m.isSynthetic() && m.getName().equals("box-impl");
if (isKotlinValueClassFactory) {
return true;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though it may be just a variable name, supporting specific use case for down stream modules such should be cautiously investigated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working PoC. Implementation details should be polished
#4066 (comment)


// 09-Nov-2020, ckozak: Avoid considering synthetic methods such as
// lambdas used within methods because they're not relevant.
return !m.isSynthetic();
}

protected AnnotatedConstructor constructDefaultConstructor(ClassUtil.Ctor ctor,
Expand Down