-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix #3503 - Implement Integer to Float coercion config #3509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3503 - Implement Integer to Float coercion config #3509
Conversation
Looks good! One thing I will need before merging in for 2.14 is the CLA from https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf which is usually easiest to do by printing, filling & signing, scan/photo, email to Looking forward to getting this improvement in, I like it! |
@Tomasito665 the code works in Java 11 but not in Java 8 - can you fix it so that the code works in Java 8 too? |
It is possible that this is due to an issue with Github actions -- to resolve, merge or rebase from |
@Tomasito665 do you intend to continue with this PR or have you abandoned it? |
I definitely hope we could get this merged, for what that is worth! |
Heyo! Sorry for the radio silence. Thanks for your comments. Had set this pull request on pause for a while while focusing on work/study. I will rebase this tomorrow on top of 2.14 and see if it works! |
Thank you @Tomasito665! Also, if and when things work, CLA would be good to get so I can merge PR. |
2a2516a
to
1e90547
Compare
1e90547
to
d4ad183
Compare
@cowtowncoder I have rebased this branch on top of With regards to the Let me know if you have found it or, if not, I will resend it. |
@Tomasito665 doh! CLA had gone into Gmail's spam folder. I should check it now and then. But yes, I got it now! |
Thank you @Tomasito665 for this contribution: it looks great, I think you got it right, impressive! This will be in 2.14.0 once released, I hope to get the first release candidate out in July. |
Description
This pull request proposes to update the
float
,Float
, andBigDecimal
deserializing logic to take into account the coercion config for integer JSON inputs. Currently, this configuration is being ignored.Issue
#3503