Fix #3419 do not generate stack trace for UnresolvedForwardReference throw internally #3422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eference thrown internally.
|
Excellent, thank you! Only one practical matter before I merge this: unless I have asked for it, I'd need CLA from here: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf (only needs to be done once before the first contribution; it's good for all future PRs) the usual way is to print, fill & sign, scan/photo, email to Once I have that I'll merge this. Thank you once again for this contribution! |
cowtowncoder
changed the title
|
CLA signed and emailed, thanks. |
|
CLA received, will merge, thanks! |
|
Merged, release notes updated, will be included in 2.14.0. Thank you very much for this improvement! |
|
Since this should be safe enough, backported in 2.13.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fix #3419)
Simply override fillInStackTrace with a noop.
I've added a secondary method _fillInStackTrace to actually fill in the stack trace when throwing a client UnresolvedForwardReferene.
If you prefer I can make this method package private.