-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Adds support for @JsonKey
annotation
#2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
src/test/java/com/fasterxml/jackson/databind/jsontype/MapSerializingTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
package com.fasterxml.jackson.databind.jsontype; | ||
|
||
import java.util.Collections; | ||
import java.util.Map; | ||
|
||
import com.fasterxml.jackson.annotation.JsonKey; | ||
import com.fasterxml.jackson.annotation.JsonValue; | ||
import com.fasterxml.jackson.databind.ObjectMapper; | ||
import org.junit.Assert; | ||
import org.junit.Ignore; | ||
import org.junit.Test; | ||
|
||
public class MapSerializingTest { | ||
class Inner { | ||
@JsonKey | ||
String key; | ||
|
||
@JsonValue | ||
String value; | ||
|
||
Inner(String key, String value) { | ||
this.key = key; | ||
this.value = value; | ||
} | ||
|
||
public String toString() { | ||
return "Inner(" + this.key + "," + this.value + ")"; | ||
} | ||
|
||
} | ||
|
||
class Outer { | ||
@JsonKey | ||
@JsonValue | ||
Inner inner; | ||
|
||
Outer(Inner inner) { | ||
this.inner = inner; | ||
} | ||
|
||
} | ||
|
||
class NoKeyOuter { | ||
@JsonValue | ||
Inner inner; | ||
|
||
NoKeyOuter(Inner inner) { | ||
this.inner = inner; | ||
} | ||
} | ||
|
||
@Test | ||
public void testClassAsKey() throws Exception { | ||
ObjectMapper mapper = new ObjectMapper(); | ||
Outer outer = new Outer(new Inner("innerKey", "innerValue")); | ||
Map<Outer, String> map = Collections.singletonMap(outer, "value"); | ||
String actual = mapper.writeValueAsString(map); | ||
Assert.assertEquals("{\"innerKey\":\"value\"}", actual); | ||
} | ||
|
||
@Test | ||
public void testClassAsValue() throws Exception { | ||
ObjectMapper mapper = new ObjectMapper(); | ||
Map<String, Outer> mapA = Collections.singletonMap("key", new Outer(new Inner("innerKey", "innerValue"))); | ||
String actual = mapper.writeValueAsString(mapA); | ||
Assert.assertEquals("{\"key\":\"innerValue\"}", actual); | ||
} | ||
|
||
@Test | ||
public void testNoKeyOuter() throws Exception { | ||
ObjectMapper mapper = new ObjectMapper(); | ||
Map<String, NoKeyOuter> mapA = Collections.singletonMap("key", new NoKeyOuter(new Inner("innerKey", "innerValue"))); | ||
String actual = mapper.writeValueAsString(mapA); | ||
Assert.assertEquals("{\"key\":\"innerValue\"}", actual); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what the code does right now; this I'm not sure if this is appropriate.